Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8891] - Remove malformed filenames from concat operation #19

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

seanavery
Copy link
Collaborator

@seanavery seanavery commented Oct 4, 2024

Description

Simple pr to remove erroneous files from file lookup and storage matcher for concats.

For example .DS_STORE files on macos will now be ignored.

Test

  • manually tested with .DS_STORE file ✅
  • added test video file with incorrect file name ✅

Copy link

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding a test file, I don't see any changes to the tests but assuming it's being tests somehow?

@seanavery
Copy link
Collaborator Author

@randhid

thanks for adding a test file, I don't see any changes to the tests but assuming it's being tests somehow?

yes, it is implicitly tested by both save and fetch tests. it does not fail with bad file name in storage dir.

@seanavery seanavery merged commit 9a6a44c into main Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants