Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually force keyframes in encoder loop #20

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

seanavery
Copy link
Collaborator

@seanavery seanavery commented Oct 7, 2024

Description

Despite having successful 24 hr runs on linux, I am still getting reports of flaky behavior on Darwin. This PR removes FFmpeg handling of keyframe forces entirely, and instead adds in manual keyframe forces in the encoder loop.

  • Removes gop_size encoder setter entirely to avoid any conflicting behavior.
  • Removes keyframe force expression.
  • Adds manual keyframe flag every second.

Testing

  • linux ✅
    • 3 hour test, 500 segments ✅
    • overnight test ✅
  • darwin ✅
    • 3 hour test, 500 segments ✅
    • overnight test ✅

Copy link
Collaborator

@hexbabe hexbabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it thanks for update

@seanavery seanavery merged commit 8324bca into main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants