Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure fragment start before synchronize to live edge #6686

Closed
wants to merge 1 commit into from

Conversation

jprorikon
Copy link

@jprorikon jprorikon commented Sep 9, 2024

This PR will...

ensure fragment start before synchronize to live edge

Why is this Pull Request needed?

player synchronized to 0.00 with bad internet conditions. which live stream level list has short fragment and small length of fragments list.

Are there any points in the code the reviewer needs to double check?

Not have any other function change

Resolves issues:

#6685

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an acceptable change. Re-syncing to the live edge is necessary in cases where media was never appended, but playlists were updated to the point that the current time or earlier sync/start time is no longer available.

@jprorikon
Copy link
Author

thanks for your reply.
I would like to draw back the pr and reconsider how to deal with Re-syncing

@jprorikon jprorikon closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants