-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to hide toast messages #64
base: test-adb-server
Are you sure you want to change the base?
Conversation
This commit was a follow up of this issue: |
Looks to me like all the other boolean settings' variable names start with |
I will probably disable toast messages if/when I can, but I'm not sure that disabling them by default is a good idea. I think the toast messges are an important part of teaching new users how MATVT works... kind of like a tutorial, and while wearable users may be more likely to want to disable the toast notifications, I think they should still get that tutorial mode by default. |
I think that renaming it to |
Sorry, the last commit wasn't meant to be pulled into the currently opened pull request. On most Desktop Operating Systems by pressing the middle click you'll switch into scroll mode, but with no pop-up being displayed, instead, the mouse icon will be replaced with some kind of "scroll icon". I'm planning to implement that feature into the MATVT project, however, isn't finished yet. |
That could be a cool enhancement, but as you said, it should probably be a seperate PR from this one. |
Yeah that is what I wanna do next, it was what I planed to do. However I new to Github so I through PR were like releases, once you submit a PR/Release further commits to source code wouldn't be bundled till next release. |
Ah, I see, you thought they were like tags. In fact, a Pull Request is an issue that has a branch associated with it. (There's even a way to attach a branch to an issue you've made to turn it into a PR.) You might also want to learn about rebasing, though you should always be extra careful when doing any procedure that rewrites history, as it's deceptively easy to mess things up and lose data. |
Thanks for the contribution. Feel free to add more commits here, I'll merge them together later. |
Synced latest changes
Revert "Synced latest changes"
A new option was added into the Other Settings section to enable users to hide toast alerts If they want to do so. For people running the app on wearables this could be really practical.