chore: Remove WebGL dependencies from data-filter-extension #9181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
commented
Sep 25, 2024
| @@ -316,27 +316,30 @@ export default class DataFilterExtension extends LayerExtension< | |||
| } = this.getAttributeManager()!; | |||
| filterModel.setVertexCount(this.getNumInstances()); | |||
|
|
|||
| this.context.device.clearWebGL({framebuffer: filterFBO, color: [0, 0, 0, 0]}); | |||
|
|
|||
| filterModel.updateModuleSettings(params.moduleParameters); | |||
There was a problem hiding this comment.
@felixpalmer Not sure how to deal with the moduleParameters they are completely untyped, not sure if they have the right structure for shaderInputs.setProps()
There was a problem hiding this comment.
Could you review #9158 ? I believe I've handled it there
|
Closing in favor of #9158 |
|
@felixpalmer That's great. Would be good to get your various PR merged before I continue on luma v9.1 integration. There is a lot of stuff that would help in review right now. Let me know if you need my attention on additional PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List