Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: parseMap support for HeatmapTileLayer #9196

Merged
merged 2 commits into from
Oct 2, 2024
Merged

CARTO: parseMap support for HeatmapTileLayer #9196

merged 2 commits into from
Oct 2, 2024

Conversation

felixpalmer
Copy link
Collaborator

Followup to #8703 to add support in fetchMap

Background

Change List

  • Support colorRange, radiusPixels and getWeight in parseMap
  • Update tests

zbigg
zbigg approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@coveralls
Copy link

Coverage Status

coverage: 91.644% (+0.005%) from 91.639%
when pulling cd1080c on felix/fetchMap-heatmapTile
into 2e9d6dc on master.

@felixpalmer felixpalmer merged commit 0342802 into master Oct 2, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/fetchMap-heatmapTile branch October 2, 2024 12:43
felixpalmer added a commit that referenced this pull request Oct 2, 2024
@felixpalmer
CARTO: parseMap support for HeatmapTileLayer (#9196)
a6dc81e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbigg zbigg zbigg approved these changes

@padawannn padawannn padawannn approved these changes

@donmccurdy donmccurdy Awaiting requested review from donmccurdy

@jmgaya jmgaya Awaiting requested review from jmgaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixpalmer @coveralls @zbigg @padawannn