Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update to use UBOs rather than setUniforms #9208

Merged
merged 3 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 69 additions & 35 deletions docs/developer-guide/custom-layers/layer-extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,43 @@ Consider a hypothetical use case: in a `ScatterplotLayer`, we inject a piece of

```js
import {ScatterplotLayer} from '@deck.gl/layers';
import type {ShaderModule} from '@luma.gl/shadertools';

// Declare uniform block & custom shader module
const uniformBlock = `\
uniform highlightUniforms {
bool enabled;
} highlight;
`;

type HighlightProps = {enabled: boolean};

const highlightUniforms = {
name: 'trips',
fs: uniformBlock, // Only need to add block to fragment stage in this example
uniformTypes: {enabled: 'f32'}
} as const satisfies ShaderModule<TripsProps>;

class FilteredScatterplotLayer extends ScatterplotLayer {
getShaders() {
return {
...super.getShaders(),
inject: {
// Declare custom uniform
'fs:#decl': 'uniform bool highlightRed;',
// Standard injection hook - see "Writing Shaders"
'fs:DECKGL_FILTER_COLOR': `
if (highlightRed) {
if (color.r / max(color.g, 0.001) > 2. && color.r / max(color.b, 0.001) > 2.) {
// is red
color = vec4(1.0, 0.0, 0.0, 1.0);
} else {
discard;
}
const shaders = super.getShaders();
shaders.inject = {
// Standard injection hook - see "Writing Shaders"
'fs:DECKGL_FILTER_COLOR': `
if (highlight.enabled) {
if (color.r / max(color.g, 0.001) > 2. && color.r / max(color.b, 0.001) > 2.) {
// is red
color = vec4(1.0, 0.0, 0.0, 1.0);
} else {
discard;
}
`
}
}
`
};

// Add uniform binding to shader modules
shaders.modules = [...shaders.modules, highlightUniforms];
return shaders;
};
}

Expand All @@ -38,9 +55,8 @@ class FilteredScatterplotLayer extends ScatterplotLayer {

if (props.highlightRed !== oldProps.highlightRed) {
// Set the custom uniform
this.state.model.setUniforms({
highlightRed: props.highlightRed
});
const highlightProps: HighlightProps = {enabled: props.highlightRed};
model.shaderInputs.setProps({highlight: highlightProps});
}
}
}
Expand Down Expand Up @@ -185,31 +201,49 @@ Back to our example use case. We can implement the red filter with the following
```js
import {LayerExtension} from '@deck.gl/core';

// Declare uniform block & custom shader module
const uniformBlock = `\
uniform highlightUniforms {
bool enabled;
} highlight;
`;

type HighlightProps = {enabled: boolean};

const highlightUniforms = {
name: 'trips',
fs: uniformBlock, // Only need to add block to fragment stage in this example
uniformTypes: {enabled: 'f32'}
} as const satisfies ShaderModule<TripsProps>;


class RedFilter extends LayerExtension {
getShaders() {
return {
inject: {
// Declare custom uniform
'fs:#decl': 'uniform bool highlightRed;',
// Standard injection hook - see "Writing Shaders"
'fs:DECKGL_FILTER_COLOR': `
if (highlightRed) {
if (color.r / max(color.g, 0.001) > 2. && color.r / max(color.b, 0.001) > 2.) {
// is red
color = vec4(1.0, 0.0, 0.0, 1.0);
} else {
discard;
}
const shaders = super.getShaders();
shaders.inject = {
// Standard injection hook - see "Writing Shaders"
'fs:DECKGL_FILTER_COLOR': `
if (highlight.enabled) {
if (color.r / max(color.g, 0.001) > 2. && color.r / max(color.b, 0.001) > 2.) {
// is red
color = vec4(1.0, 0.0, 0.0, 1.0);
} else {
discard;
}
`
}
}
`
};

// Add uniform binding to shader modules
shaders.modules = [...shaders.modules, highlightUniforms];
return shaders;
}

updateState(params) {
const {highlightRed = true} = params.props;
for (const model of this.getModels()) {
model.setUniforms({highlightRed});
const highlightProps: HighlightProps = {enabled: props.highlightRed};
model.shaderInputs.setProps({highlight: highlightProps});
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/custom-layers/layer-lifecycle.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ If the layer does need to be updated,
is called to perform any necessary operation before the layer is rendered.
This usually involves recalculating an attribute by calling
[`state.attributeManager.invalidate`](../../api-reference/core/attribute-manager.md#invalidate)
and updating uniforms by calling `model.setUniforms`.
and updating uniforms by calling `model.shaderInputs.setProps({...})`.
By default, when `props.data` changes, all attributes are invalidated and recalculated.

A composite layer may use
Expand Down
1 change: 1 addition & 0 deletions docs/table-of-contents.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"developer-guide/custom-layers/picking",
"developer-guide/custom-layers/composite-layers",
"developer-guide/custom-layers/subclassed-layers",
"developer-guide/custom-layers/layer-extensions",
"developer-guide/custom-layers/primitive-layers",
"developer-guide/custom-layers/prop-types",
"developer-guide/custom-layers/attribute-management",
Expand Down
Loading