Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure base path ends with forward slash #710

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PanMisza
Copy link

@PanMisza PanMisza commented May 5, 2024

Right now, this plugin assumes that the base path always ends with a forward slash (/). However, this is not always the case.

When we set the base as, for example /app, the browser will try to download /appmanifest.webmanifest and /appsw.js

This PR resolves that case.

Copy link

netlify bot commented May 5, 2024

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 1892bed
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6637da963c0aef00087e5833
😎 Deploy Preview https://deploy-preview-710--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants