-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix load config when using bools #9533
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
if value: | ||
processed_args.append('--' + key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have some boolean arguments that aren't just store_true. I know you can specify --trust-remote-code=True
on the CLI so maybe the issue could also be solved by the mismatch of capitalization on true vs True - what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched for store_false
on this file: https://github.com/vllm-project/vllm/blob/main/vllm/engine/arg_utils.py and couldn't find any instances of it.
However, with a second look, there's two types of boolean flags:
action='store_true'
eg--trust-remote-code
action=StoreBoolean
eg--disable-logprobs-during-spec-decoding
.
In the store_true case, --trust-remote-code=True
doesn't work eg run vllm serve facebook/opt-125m --trust-remote-code=True
and it errors with vllm serve: error: argument --trust-remote-code: ignored explicit argument 'True'
.
In the StoreBoolean
case, --disable-logprobs-during-spec-decoding=True
does work.
So I think my code needs to add an extra check for these StoreBoolean arguments and explicitly set the value in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the PR to handle StoreBoolean
values.
- Moved StoreBoolean to vllm/utils.py to avoid circular imports
- Updated the _load_config_from_file to not be static so it can check which arguments are in StoreBoolean case
- Added a check for the StoreBoolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you were right about the difference there, but yes I was referring to the usage of StoreBoolean
! Thanks for looking into this
Hi @mgoin, thanks for taking the time to look over this. What's the process for getting this reviewed? First time contributing here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ask and ping related folks, as you did. I think this is good to go, thanks!
45e1af4
to
cc7c75b
Compare
Thanks @mgoin! There's a failing test buildkite/ci-aws/pr/distributed-tests-2-gpus which is failing. I tried rebasing onto main but also seems to be also failing on main branch so unlikely to be related to the change. Can you bypass the requirements please and merge this? Or let me know if there's some other way I should be fixing this. |
Signed-off-by: madt2709 <theodore.dias@hotmail.co.uk>
Signed-off-by: madt2709 <theodore.dias@hotmail.co.uk>
cc7c75b
to
0431d2d
Compare
Fixes #9499
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.
Tensors
require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.torch.libary.opcheck()
to test the function registration and meta-function for any registered ops. Seetests/kernels
for examples.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!