-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV-210932 Improve UT runtime #1339
base: master
Are you sure you want to change the base?
Conversation
No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR. |
build ako |
@aaha97 UT time seems to be improved by 20 min. Can we do one more experiment... can we check impact of increasing value of |
No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR. |
build ako |
29f41fe
to
db8cac6
Compare
No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR. |
skip jira-id-check |
build ako |
2 similar comments
build ako |
build ako |
db8cac6
to
c328e8f
Compare
No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR. |
build ako |
1 similar comment
build ako |
No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR. |
df6e2d6
to
39cd97b
Compare
update UTs, seperate tests using different names for resources skip TestMultiHostIngressStatusCheck due to status update concurrency issue. addressed in another PR separate gateway api tests servicesapitests fixes, add clean cache command avi-lb creation fix rebasing PR
39cd97b
to
7eaf9e5
Compare
build ako |
3 similar comments
build ako |
build ako |
build ako |
build ako |
build ako |
build ako |
1 similar comment
build ako |
@@ -2125,6 +2125,10 @@ func SetupIngressClass(t *testing.T, ingclassName, controller, infraSetting stri | |||
t.Fatalf("error in adding IngressClass: %v", err) | |||
} | |||
} | |||
if len(wait) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for informer to reflect the change is better than waiting for constant time.
https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/pull/1541/files#diff-65203e7df4245516a3ff56807dac4609eca286c0706102103b62a025a137e40cR2129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
|
||
.PHONY: int_test | ||
int_test: | ||
make -j 1 k8stest integrationtest ingresstests evhtests vippernstests dedicatedevhtests dedicatedvippernstests oshiftroutetests bootuptests multicloudtests advl4tests namespacesynctests servicesapitests npltests misc dedicatedvstests hatests calicotests ciliumtests helmtests infratests urltests gatewayapitests | ||
make -j 8 bootuptests ciliumtests k8stest multicloudtests \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would need more clarification on how are we going to identify the error in case of failure.
efe6ac0
to
281229c
Compare
build ako |
1 similar comment
build ako |
build ako |
2 similar comments
build ako |
build ako |
79919c3
to
22df92b
Compare
build ako |
Run UTs in a single container, avoid running
docker run
with each make targetisolating test cases by using different names for resources created in test cases