-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV-219152 Moving HTTPRoute Validation to Graph layer #1547
Conversation
Ut run result:
|
29038ae
to
d338a41
Compare
UT run after changes:
|
d338a41
to
fae4a1e
Compare
fae4a1e
to
90e7742
Compare
UT run result:
|
httpRoute, err := akogatewayapilib.AKOControlConfig().GatewayApiInformers().HTTPRouteInformer.Lister().HTTPRoutes(namespace).Get(name) | ||
if err == nil { | ||
utils.AviLog.Debugf("key: %s, msg: Successfully retrieved the HTTPRoute object %s", key, name) | ||
if !IsHTTPRouteValid(key, httpRoute) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkoshtavmware: Should we include this as part of HTTPRouteChanges
function? How transition from valid httproute to invalid HTTP route will be handled with return into picture? Are we deleting previously created objects with invalid transition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be taken care as part of partial listener PR
ako-gateway-api/status/status.go
Outdated
@@ -80,7 +84,7 @@ func BulkUpdate(key string, objectType string, options []status.StatusOptions) e | |||
return nil | |||
} | |||
|
|||
func Record(key string, obj runtime.Object, status *Status) { | |||
func Record(key string, obj runtime.Object, status *Status) (runtime.Object, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkoshtavmware: I think we are not using return value runtime.Object
anywhere. Can we take it out (in nested calls also)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
90e7742
to
61fd0fb
Compare
3a0926a
to
1470d44
Compare
1470d44
to
a0dc1a3
Compare
a0dc1a3
to
8e9e36d
Compare
Ut runs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments.
httpRoute, err := akogatewayapilib.AKOControlConfig().GatewayApiInformers().HTTPRouteInformer.Lister().HTTPRoutes(namespace).Get(name) | ||
if err == nil { | ||
utils.AviLog.Debugf("key: %s, msg: Successfully retrieved the HTTPRoute object %s", key, name) | ||
if !IsHTTPRouteValid(key, httpRoute) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be taken care as part of partial listener PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AV-219152 Moving HTTPRoute Validation to Graph layer