AV-219152 Moving HTTPRoute Validation to Graph layer #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FT run result:
|
|
Ut run result: |
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
29038ae
to
d338a41
Compare
|
UT run after changes: |
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
d338a41
to
fae4a1e
Compare
pkoshtavmware
requested review from
akshayhavile,
arihantg,
aaha97,
DixitAakash,
ashishnayak96 and
apalsule
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
fae4a1e
to
90e7742
Compare
|
FT run result: |
|
UT run result: |
akshayhavile
reviewed
Oct 7, 2024
| httpRoute, err := akogatewayapilib.AKOControlConfig().GatewayApiInformers().HTTPRouteInformer.Lister().HTTPRoutes(namespace).Get(name) | ||
| if err == nil { | ||
| utils.AviLog.Debugf("key: %s, msg: Successfully retrieved the HTTPRoute object %s", key, name) | ||
| if !IsHTTPRouteValid(key, httpRoute) { |
There was a problem hiding this comment.
@pkoshtavmware: Should we include this as part of HTTPRouteChanges function? How transition from valid httproute to invalid HTTP route will be handled with return into picture? Are we deleting previously created objects with invalid transition?
There was a problem hiding this comment.
This will be taken care as part of partial listener PR
ako-gateway-api/status/status.go
Outdated
| @@ -80,7 +84,7 @@ func BulkUpdate(key string, objectType string, options []status.StatusOptions) e | |||
| return nil | |||
| } | |||
|
|
|||
| func Record(key string, obj runtime.Object, status *Status) { | |||
| func Record(key string, obj runtime.Object, status *Status) (runtime.Object, error) { | |||
There was a problem hiding this comment.
@pkoshtavmware: I think we are not using return value runtime.Object anywhere. Can we take it out (in nested calls also)?
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
90e7742
to
61fd0fb
Compare
pkoshtavmware
force-pushed
the
AV-219152-master
branch
2 times, most recently
from
3a0926a
to
1470d44
Compare
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
1470d44
to
a0dc1a3
Compare
pkoshtavmware
force-pushed
the
AV-219152-master
branch
from
a0dc1a3
to
8e9e36d
Compare
|
Ut runs: |
akshayhavile
approved these changes
Oct 8, 2024
| httpRoute, err := akogatewayapilib.AKOControlConfig().GatewayApiInformers().HTTPRouteInformer.Lister().HTTPRoutes(namespace).Get(name) | ||
| if err == nil { | ||
| utils.AviLog.Debugf("key: %s, msg: Successfully retrieved the HTTPRoute object %s", key, name) | ||
| if !IsHTTPRouteValid(key, httpRoute) { |
There was a problem hiding this comment.
This will be taken care as part of partial listener PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AV-219152 Moving HTTPRoute Validation to Graph layer