AV-206859 Setting ResolvedRef Condition in HTTProute #1558

pkoshtavmware · 2024-10-18T08:59:16Z

AV-206859 Setting ResolvedRef Condition in HTTProute

Testing Status:
Manual Testing done
Unit TestCase added

pkoshtavmware · 2024-10-18T09:33:14Z

Ut run result:

        github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests               coverage: 0.0% of statements
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/graphlayer    448.268s        coverage: 18.4% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/ingestion     220.704s        coverage: 2.8% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/npltests      60.479s coverage: 15.7% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/status        301.047s        coverage: 12.8% of statements in ./...

ashishnayak96 · 2024-10-22T08:43:39Z

ako-gateway-api/nodes/avi_model_l7_translator.go

+	_, namespace, name := lib.ExtractTypeNameNamespace(routeTypeNsName)
+	httpRoute, err := akogatewayapilib.AKOControlConfig().GatewayApiInformers().HTTPRouteInformer.Lister().HTTPRoutes(namespace).Get(name)
+	if err != nil {
+		utils.AviLog.Debugf("key: %s, msg: Unable to extract the HTTPRoute object %s for BackendRef validation", key, name)


This should be Warn or Error?

ashishnayak96 · 2024-10-22T09:10:18Z

ako-gateway-api/nodes/route_model.go

@@ -295,6 +296,9 @@ func (hr *httpRoute) ParseRouteConfig() *RouteConfig {
 				//Default 0
 				backend.Port = int32(*ruleBackend.Port)
 			}
+			if ruleBackend.BackendRef.Kind != nil {
+				backend.Kind = string(*ruleBackend.Kind)
+			}


should we by default add Services?

If we do not add anything for Kind, as in if we keep kind as "", by default Service gets added as kind

ashishnayak96 · 2024-10-22T09:16:17Z

tests/gatewayapitests/status/httproute_test.go

+		map[string][]string{"RequestHeaderModifier": {"add", "remove", "replace"}},
+		[][]string{{"avisvc", "default", "8080", "1"}}, nil)
+	kind := gatewayv1.Kind("InvalidKind")
+	rule.BackendRefs[0].BackendRef.Kind = &kind


Can we have additional unit test with two backends, one invalid and one valid and then check for Conditions

akshayhavile · 2024-10-23T08:05:12Z

ako-gateway-api/nodes/avi_model_l7_translator.go

 	for _, httpbackend := range rule.Backends {
+		isValidBackend, resolvedRefConditionforBackend := validateBackendReference(key, *httpbackend.Backend, httpRoute)


I think we should include this logic as part of ParseRouteConfig instead of writing down over here. Advantage: We will separate of parsing (and setting of httproute object) from logic of populating AviController objects. Also we will save one Informer call.

akshayhavile · 2024-10-23T08:08:16Z

tests/gatewayapitests/graphlayer/httproute_test.go

@@ -764,8 +764,8 @@ func TestHTTPRouteBackendServiceCDC(t *testing.T) {
 			return 0
 		}
 		nodes := aviModel.(*avinodes.AviObjectGraph).GetAviEvhVS()
-		return len(nodes[0].EvhNodes[0].PoolGroupRefs[0].Members)
-	}, 25*time.Second).Should(gomega.Equal(1))
+		return len(nodes[0].EvhNodes[0].PoolGroupRefs)


should we have .Members condition also (Which is removed)

pkoshtavmware · 2024-10-24T10:29:53Z

Ut run result:

        github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests               coverage: 0.0% of statements
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/graphlayer    448.181s        coverage: 18.4% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/ingestion     220.647s        coverage: 2.7% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/npltests      60.348s coverage: 16.0% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/status        328.979s        coverage: 16.9% of statements in ./...

pkoshtavmware · 2024-10-24T12:48:58Z

akshayhavile · 2024-10-24T12:55:50Z

ako-gateway-api/nodes/route_model.go

-			routeConfigRule.Backends = append(routeConfigRule.Backends, httpBackend)
+			isValidBackend, resolvedRefConditionforBackend := validateBackendReference(key, *backend, hr)
+			if isValidBackend {
+				httpBackend.IsValid = true


@pkoshtavmware: We do not require IsValid field as we are appending valid Backends only to routeConfigRule.Backends which is being parsed in Graph layer function.

akshayhavile · 2024-10-24T12:57:05Z

ako-gateway-api/nodes/route_model.go

+			} else {
+				hasInvalidBackend = true
+				resolvedRefCondition = resolvedRefConditionforBackend
+				continue


why continue is required over here?

ashishnayak96 · 2024-10-25T05:54:36Z

build ako

pkoshtavmware · 2024-10-25T06:27:11Z

Unit Test run:

        github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests               coverage: 0.0% of statements
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/graphlayer    448.278s        coverage: 18.4% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/ingestion     220.705s        coverage: 2.8% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/npltests      60.442s coverage: 15.9% of statements in ./...
ok      github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/tests/gatewayapitests/status        329.120s        coverage: 17.0% of statements in ./...

pkoshtavmware · 2024-10-25T10:14:40Z

pkoshtavmware added testing-in-progress do-not-review labels Oct 18, 2024

pkoshtavmware force-pushed the AV-206859-master branch from 1ab68e5 to 7283ee5 Compare October 19, 2024 07:08

pkoshtavmware requested review from akshayhavile and ashishnayak96 October 19, 2024 07:08

pkoshtavmware assigned akshayhavile and ashishnayak96 Oct 19, 2024

pkoshtavmware added open-for-review Pull request is up for review and removed testing-in-progress do-not-review labels Oct 19, 2024

pkoshtavmware requested review from apalsule, DixitAakash and aaha97 October 21, 2024 07:00

ashishnayak96 reviewed Oct 22, 2024

View reviewed changes

pkoshtavmware force-pushed the AV-206859-master branch from 7283ee5 to 7e51bfe Compare October 22, 2024 08:49

ashishnayak96 reviewed Oct 22, 2024

View reviewed changes

pkoshtavmware force-pushed the AV-206859-master branch from 7e51bfe to ae7bd8b Compare October 23, 2024 06:30

pkoshtavmware requested a review from ashishnayak96 October 23, 2024 06:32

akshayhavile reviewed Oct 23, 2024

View reviewed changes

pkoshtavmware force-pushed the AV-206859-master branch 3 times, most recently from 5364ef9 to 2021ef1 Compare October 24, 2024 10:28

pkoshtavmware requested a review from akshayhavile October 24, 2024 10:30

akshayhavile reviewed Oct 24, 2024

View reviewed changes

pkoshtavmware force-pushed the AV-206859-master branch from 2021ef1 to e20fd14 Compare October 25, 2024 06:26

pkoshtavmware requested a review from akshayhavile October 25, 2024 08:47

AV-206859 Setting ResolvedRef Condition in HTTProute

102e1ed

pkoshtavmware force-pushed the AV-206859-master branch from e20fd14 to 102e1ed Compare October 25, 2024 09:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AV-206859 Setting ResolvedRef Condition in HTTProute #1558

AV-206859 Setting ResolvedRef Condition in HTTProute #1558

pkoshtavmware commented Oct 18, 2024 •

edited

Loading

pkoshtavmware commented Oct 18, 2024

ashishnayak96 Oct 22, 2024

pkoshtavmware Oct 23, 2024

ashishnayak96 Oct 22, 2024

pkoshtavmware Oct 22, 2024

ashishnayak96 Oct 22, 2024

pkoshtavmware Oct 23, 2024

akshayhavile Oct 23, 2024

pkoshtavmware Oct 24, 2024

akshayhavile Oct 23, 2024

pkoshtavmware Oct 24, 2024

pkoshtavmware commented Oct 24, 2024

pkoshtavmware commented Oct 24, 2024

akshayhavile Oct 24, 2024

pkoshtavmware Oct 25, 2024

akshayhavile Oct 24, 2024

pkoshtavmware Oct 25, 2024

ashishnayak96 commented Oct 25, 2024

pkoshtavmware commented Oct 25, 2024

pkoshtavmware commented Oct 25, 2024

		for _, httpbackend := range rule.Backends {
		isValidBackend, resolvedRefConditionforBackend := validateBackendReference(key, *httpbackend.Backend, httpRoute)

AV-206859 Setting ResolvedRef Condition in HTTProute #1558

Are you sure you want to change the base?

AV-206859 Setting ResolvedRef Condition in HTTProute #1558

Conversation

pkoshtavmware commented Oct 18, 2024 • edited Loading

pkoshtavmware commented Oct 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkoshtavmware commented Oct 24, 2024

pkoshtavmware commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashishnayak96 commented Oct 25, 2024

pkoshtavmware commented Oct 25, 2024

pkoshtavmware commented Oct 25, 2024

pkoshtavmware commented Oct 18, 2024 •

edited

Loading