Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 2750: filter and <vip> tag can support customized vipconfig name #2828

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

huihuiw01
Copy link
Contributor

No description provided.

logger.error(e.getMessage());
}
gc.createFormattingCache(FormattingCache.class);
I18nFactory i18n = I18nFactory.getInstance(gc);

Check notice

Code scanning / Pmd (reported by Codacy)

Avoid unused local variables such as 'i18n'. Note test

Avoid unused local variables such as 'i18n'.
logger.error(e.getMessage());
}
gc.createTranslationCache(MessageCache.class);
I18nFactory i18n = I18nFactory.getInstance(gc);

Check notice

Code scanning / Pmd (reported by Codacy)

Avoid unused local variables such as 'i18n'. Note test

Avoid unused local variables such as 'i18n'.
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (g11n-java-client@f1f6a90). Click here to learn what that means.

Files Patch % Lines
...ware/vipclient/i18n/fmt/common/MessageSupport.java 0.00% 6 Missing ⚠️
...are/vipclient/i18n/filters/VIPComponentFilter.java 50.00% 2 Missing and 1 partial ⚠️
...mware/vipclient/i18n/filters/VIPPatternFilter.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             g11n-java-client    #2828   +/-   ##
===================================================
  Coverage                    ?   56.45%           
  Complexity                  ?      989           
===================================================
  Files                       ?      114           
  Lines                       ?     5755           
  Branches                    ?     1006           
===================================================
  Hits                        ?     3249           
  Misses                      ?     1970           
  Partials                    ?      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huihuiw01 huihuiw01 merged commit e6790c9 into vmware:g11n-java-client Mar 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants