-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openldap: update to 2.6.6 #41948
openldap: update to 2.6.6 #41948
Conversation
Turns out test079 fails because arguments after the filter for ldapsearch seem to be ignored on musl. Added a patch that moves the filter last. |
The test suite for mit-krb5 seems to fail now instead. That package is out of date as well. May try to update it and see if it solves the problem. |
Still lacking a few revbumps. Will look into them later. |
8a7548c
to
6fd0263
Compare
That should be most revbumps. Now to see about build testing. |
Fix some build issues. Still have failures in anjuta, log4cxx and virtuoso. |
Fix log4cxx build issue. |
Fixed anjuta build issue. |
Managed to get newest version of virtuoso to build but it still fails the test suite. |
The test suite for vitruoso was failing due to missing checkdepends... All revbumped or updated packages now complete their test suite if they have one on x86_64-glibc. I'm going to run this on x86_64-musl as well but it will take longer as that machine is a lot less powerful. |
On x86_64-musl tests fail for audit, dovecot-plugin-pigeonhole, dovecot, evolution-data-server, evolution and nss-pam-ldapd. nss-pam-ldapd and sssd are expected as musl lacks support for nsswitch. On dovecot and dovecot-plugin-pigeonhole a single test fails:
audit fails in auparse test:
For evolution and evolution-data-server a bunch of tests fail with similar output to:
audit.log |
Did some tests on the master branch and x86_64-musl. When I looked closer on dovecot-plugin-pigeonhole it fails in this PR because it couldn't build dovecot as the test suite is failing. If I build dovecot first without checks dovecot-plugin-pigeonhole it succeeds with the commits in this PR. Updated log for dovecot pigeonhole in this PR: Logs from builds on master branch: So from what I can see there are no new failures caused by this PR. I'll do some more crossbuilds but I think after that this PR is starting to be ready. Regarding the backup/restore of the ldap database, should that be notified on upgrade? Skipping this step can potentially corrupt the database but I guess anyone using openldap in server mode should be aware of that and have periodic backups anyway but I don't know if that's something we can depend on. |
I feel confident enough about the changes that I will mark this as ready. Please tell me if there's any other testing or changes that should be done. |
Do you mind checking that these build with openssl 3? |
See #42054 |
I'll give openssl 3 a go. I don't mind you updating squid in the separate PR, but will pull in that as well in my testing. This will probably take longer to merge than your PR. |
sssd is already faulty as is. I was trying to update it in #40846, but I have no means to test it since I have nothing to set it up for. |
sssd will probably not work on musl as musl lacks native support for nsswitch. There is musl-nscd that implements this via nscd but I haven't been able to get that to work when I tried it earlier. I could spin up a void linux machine with glibc to test sssd though. |
also fix some linting problems
8ff3a31
to
bbfc8b4
Compare
Seems I somehow dropped evolution-data-server when rebasing, sorry about that. |
The 2.4 branch is not maintained anymore and I don't know if there's much advantage to going to 2.5 instead of 2.6
Some shared libraries have changed name so this updates common/shlibs.
As this is a major update the ldap database should be backed up and recreated as per https://www.openldap.org/doc/admin26/maintenance.html
Testing the changes
I have upgraded my ldap setup to this version. It's not very complicated so may not be great for coverage.
Basically:
This PR should not be merged before:
[ci skip] again.
Local build testing
(updated 2023-08-23)
I built this PR locally for my native architecture, (x86_64-glibc):
I built this PR locally for my native architecture, (x86_64-musl):
Crossbuilds