Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: josm-19160 #45150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TinfoilSubmarine
Copy link
Contributor

@TinfoilSubmarine TinfoilSubmarine commented Jul 20, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

@paper42 paper42 added the new-package This PR adds a new package label Jul 20, 2023
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-18772 New package: josm-18789 Aug 8, 2023
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-18789 New package: josm-18822 Sep 21, 2023
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 21, 2023
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-18822 New package: josm-18907 Dec 21, 2023
@github-actions github-actions bot removed the Stale label Dec 22, 2023
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-18907 New package: josm-18969 Feb 8, 2024
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-18969 New package: josm-19039 Apr 29, 2024
@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-19039 New package: josm-19128 Jul 19, 2024
@Emru1
Copy link
Contributor

Emru1 commented Jul 31, 2024

Builded and installed, but when I launch it:

Using /usr/lib/jvm/openjdk17/bin/java to execute josm.
Error occurred during initialization of boot layer
java.lang.module.FindException: Module javafx.web not found

@Emru1
Copy link
Contributor

Emru1 commented Jul 31, 2024

Launching it manually, without this debian scipt installed in /usr/bin/josm works properly

@TinfoilSubmarine
Copy link
Contributor Author

Could you try with the latest version I just pushed? It has a patch that strips out the Debian-specific stuff from /usr/bin/josm. That is the only change I made.

@TinfoilSubmarine
Copy link
Contributor Author

...which of course means we should just be using Void's canonical way of finding the correct jre, which is of course just using the java available on path, which is what you were saying in the first place. I'll update this to just do that when I get a chance instead of using the unnecessary included script.

@TinfoilSubmarine TinfoilSubmarine changed the title New package: josm-19128 New package: josm-19160 Aug 4, 2024
@Emru1
Copy link
Contributor

Emru1 commented Aug 11, 2024

now it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants