Some cython updates on top of #45086 #45161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch for python3-Cython-3.0.0.
|
I'm sorry, this was meant to go as a PR on my fork since it's just to get my patches in to run CI and make them available.
|
|
Sigh, thanks for catching the pybind11 incompatibility. I fixed this on master already and incorporated all of your commits to date in my cython PR. You can close this PR, or you can leave it open and add any later commits after rebasing on my current branch. (You can also PR against the cython branch on my void-packages fork and I'll pull your changes there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #45086 here I fix
The strategy is to be as minimal as possible, e.g. mostly use
legacy_implicit_noexcept=Trueand other legacy options when needed, rather than patch.I'm still working on sagemath, but this should cover all its deps.
@ahesford