groff: update to 1.23.0.

[icp1994]

Testing the changes

• I tested the changes in this PR: briefly

Local build testing

• I built this PR locally for my native architecture: x86_64

• site.tmac changes from Arch repo
• --with-doc configure option removed upstream, builds/installs docs by default
• ${DESTDIR}/usr/lib is empty, so no more libgroff - although can't find it mentioned in the changelog (which is a whole novel)

[g-branden-robinson]

Hi there,

Interested novelist here.

* `--with-doc` configure option removed upstream, builds/installs docs by default

Half-true. Docs are built by the default make target, but install-doc is still required to install them. This is an Automake convention that I am not thrilled with.

* `${DESTDIR}/usr/lib` is empty, so no more `libgroff` - although can't find it mentioned in the changelog (which is [a whole novel](https://git.savannah.gnu.org/cgit/groff.git/tree/ChangeLog.123))

It wasn't ever supposed to be there. libgroff, like a handful of others in the groff source tree, is internal. It has no published or supported API, it is not documented at all, it is built as a static object, and it is statically linked with the executables that need it. If anyone was ever shipping libgroff.a, they were in error.

[icp1994]

Thank you for your inputs. The libgroff package in Void wasn't actually shipping libgroff.a, rather the following files (i.e., everything installed under "$destdir/usr/lib")

/usr/lib/groff/glilypond/args.pl
/usr/lib/groff/glilypond/oop_fh.pl
/usr/lib/groff/glilypond/subs.pl
/usr/lib/groff/gpinyin/subs.pl
/usr/lib/groff/groff_opts_no_arg.txt
/usr/lib/groff/groff_opts_with_arg.txt
/usr/lib/groff/groffer/main_subs.pl
/usr/lib/groff/groffer/man.pl
/usr/lib/groff/groffer/split_env.sh
/usr/lib/groff/groffer/subs.pl
/usr/lib/groff/groffer/version.sh
/usr/lib/groff/grog/subs.pl

The changelog mentions that groffer/*, groff_opts_{no,with}_arg.txt, and grog/subs.pl were all removed. Although not sure about the other ones.

[g-branden-robinson]

Thank you for your inputs. The libgroff package in Void wasn't actually shipping libgroff.a, rather the following files (i.e., everything installed under "$destdir/usr/lib")

Ah, thanks, I had forgotten about those since refactoring them away.

The changelog mentions that groffer/*, groff_opts_{no,with}_arg.txt, and grog/subs.pl were all removed. Although not sure about the other ones.

Yes, grog, groffer, gpinyin, and glilypond (all written by the same contributor) had a similar structure, and on the groff development mailing list we thought it would be simpler if these programs all became stand-alone scripts. So everything they need is now embedded in their executables in $DESTDIR/bin. Except for groffer, which we withdrew entirely.

You didn't find them in the ChangeLog because items in the contrib directory in groff's source distribution (usually) maintain their own change log files as a consequence of their somewhat independent history. Our LICENSES file suggests the basis for this, and our HACKING file covers it explicitly.

The Git history is probably easier to search because it records the changes to everything in one place.

commit 427a5cb1fc6761a0fd6e338d23732522b02804b0
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Oct 9 07:00:05 2022 -0500

    [glilypond]: Make script stand alone.
    
    * contrib/glilypond/args.pl:
    * contrib/glilypond/oop_fh.pl
    * contrib/glilypond/subs.pl: Delete, moving their content into...
    * contrib/glilypond/glilypond.pl: ...here.  Also bump overall license to
      GPLv3 from GPLv2 because all of the deleted files were GPLv3.
    * contrib/glilypond/glilypond.am (dist_glilypond_DATA): Delete.

commit 92c5da8134a0209b7bf34e6f92bfa8218197d485
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Oct 9 05:56:36 2022 -0500

    [gpinyin]: Make script stand alone.
    
    * contrib/gpinyin/subs.pl: Delete, moving its content into...
    
    * contrib/gpinyin/gpinyin.pl: ...here.
    
      (vowel_t): Use explicit list with `my`.
    
      (vowel_n, vowel_t): Declare local scalar $vowel_with_tone using `my`.
    
    * contrib/gpinyin/gpinyin.am (dist_gpinyin_DATA): Delete.

Does this help?

[icp1994]

Yes, appreciate the explanation.