Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giac: fix #include <giac/giac.h> in musl #45735

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

tornaria
Copy link
Contributor

As reported in #45708 (comment), including <giac/giac.h> fails in musl because the HAVE_TGAMMAF macro from autotools is not available at this time.

Here we include a patch adapted from geogebra/giac@618a5de which is the solution upstream will include in next release of giac.

We need to fix this now so we can build sagemath in musl!

Testing the changes

  • I tested the changes in this PR: YES

@tornaria
Copy link
Contributor Author

Note all the added patch does is moving the definition of inline float fgamma() verbatim from first.h to usual.cc which is the only place where it is used.

In the template I added a simple test in post_install() that compiles #include <giac/giac.h> to make sure it works.

As reported in void-linux#45708, including <giac/giac.h> fails in musl because the
HAVE_TGAMMAF macro from autotools is not available at this time.

Here we include a patch adapted from
geogebra/giac@618a5de
which is the solution upstream will include in next release of giac.

We need to fix this now so we can build sagemath in musl!
@tornaria
Copy link
Contributor Author

tornaria commented Aug 24, 2023

My bad, I was using gcc to test compilation using #include <giac/giac.h> but that doesn't work in cross. Fixing it now by using ${CC} instead.

@leahneukirchen leahneukirchen merged commit e9cf7d8 into void-linux:master Aug 26, 2023
8 checks passed
@tornaria tornaria deleted the giac branch August 27, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants