New package: abaddon-0.2.1

[rookiejet]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

[MIvanchev]

I tested it as well, seems to work fine (glibc x86_64)

[MIvanchev]

Thank you for maintaining that package! Just 1 thing, abaddon doesn't currently install an icon so the entry in the .desktop file is wrong. Maybe it's better to remove the line.

Also you need a depends="desktop-file-utils" because of the desktop file and later on depends="desktop-file-utils hicolor-icon-theme" when there is an icon.

[rookiejet]

Thanks for the suggestions. Do you know if there is a failure case if the icon entry is included without an icon? It seems to validate fine. I'd prefer to leave it because I'd likely forget to add it later.

Can you also clarify why hicolor-icon-theme is required? My understanding is it is depended on if the app uses icons from the desktop icon theme for e.g. in its buttons, which abaddon does not do.

[MIvanchev]

Thanks for the suggestions. Do you know if there is a failure case if the icon entry is included without an icon? It seems to validate fine. I'd prefer to leave it because I'd likely forget to add it later.

Void doesn't validate the file at all. With my launcher (xlunch) there isn't any icon in this case (icon specified but not found) whereas xlunch puts a generic icon if there is no icon specified at all. So for me nothing is slightly better but different launchers likely handle this in their own manner.

Can you also clarify why hicolor-icon-theme is required? My understanding is it is depended on if the app uses icons from the desktop icon theme for e.g. in its buttons, which abaddon does not do.

IMO the package is required if you use something from /usr/share/icons/hicolor even if you put it there but I'm not 100% certain.

[rookiejet]

I should clarify, I meant validate using desktop-file-validate, but I assume that is only checking syntax. Letting menus display a generic icon if they can is probably better, I will remove the icon line then. Thanks.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.