-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: abaddon-0.2.1 #46753
base: master
Are you sure you want to change the base?
New package: abaddon-0.2.1 #46753
Conversation
2719407
to
3fc8cab
Compare
3fc8cab
to
cb2c92c
Compare
cb2c92c
to
df8f0b4
Compare
df8f0b4
to
03f97d9
Compare
03f97d9
to
8707af9
Compare
8707af9
to
6ec6d06
Compare
6ec6d06
to
d0921a4
Compare
d0921a4
to
85ae1d7
Compare
I tested it as well, seems to work fine (glibc x86_64) |
85ae1d7
to
d5bf72d
Compare
Thank you for maintaining that package! Just 1 thing, abaddon doesn't currently install an icon so the entry in the .desktop file is wrong. Maybe it's better to remove the line. Also you need a |
Thanks for the suggestions. Do you know if there is a failure case if the icon entry is included without an icon? It seems to validate fine. I'd prefer to leave it because I'd likely forget to add it later. Can you also clarify why |
d5bf72d
to
ab25b88
Compare
ab25b88
to
9d55394
Compare
Void doesn't validate the file at all. With my launcher (xlunch) there isn't any icon in this case (icon specified but not found) whereas xlunch puts a generic icon if there is no icon specified at all. So for me nothing is slightly better but different launchers likely handle this in their own manner.
IMO the package is required if you use something from |
I should clarify, I meant validate using |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
9d55394
to
2770ff3
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package