Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: sing geoip and geosite #51283

Closed
wants to merge 3 commits into from
Closed

New packages: sing geoip and geosite #51283

wants to merge 3 commits into from

Conversation

hesam-init
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 16, 2024
@Clos3y
Copy link
Contributor

Clos3y commented Jul 17, 2024

Both packages have scheduled, automated releases, so I think this probably isn't inline with the packaging requirements,

Software need to be used in version announced by authors as ready to use by the general public - usually called releases.
Betas, arbitrary VCS revisions, templates using tip of development branch taken at build time and releases created by the package maintainer won't be accepted.
but I could be wrong

EDIT: You also need to squash your commits.

@hesam-init
Copy link
Contributor Author

Both packages have scheduled, automated releases, so I think this probably isn't inline with the packaging requirements,

Software need to be used in version announced by authors as ready to use by the general public - usually called releases.
Betas, arbitrary VCS revisions, templates using tip of development branch taken at build time and releases created by the package maintainer won't be accepted.

but I could be wrong
EDIT: You also need to squash your commits.

I will close this request due to a lint issue and will open a new one.

@hesam-init
Copy link
Contributor Author

Both packages have scheduled, automated releases, so I think this probably isn't inline with the packaging requirements,

Software need to be used in version announced by authors as ready to use by the general public - usually called releases.
Betas, arbitrary VCS revisions, templates using tip of development branch taken at build time and releases created by the package maintainer won't be accepted.

but I could be wrong
EDIT: You also need to squash your commits.

I also should mention These packages are requirements for the Nekoray client. After merging these two packages, I will push the Nekoray template.

@hesam-init hesam-init closed this Jul 18, 2024
@classabbyamp
Copy link
Member

don't close and open new PRs, amend and force push instead. new PRs are lots of noise and they separate the review history

if you're adding dependencies of a package, add them and the package that needs them in one PR.

#51326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants