Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamescope: update to 3.14.24. #51351

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

dexgs
Copy link
Contributor

@dexgs dexgs commented Jul 20, 2024

Gamescope upstream has made it very clear that they explicitly want distros to use their vendored dependencies, not system packages. This commit respects all their vendored dependencies.

This PR depends on #51341 as the latest gamescope depends on a newer version of libdecor than is currently packaged.

Thanks to @CaitCatDev for starting off the updated template. I've made some corrections to the dependencies and set -Wno-error specifically for the warnings that were causing problems building libliftoff and wlroots rather than turning off werror entirely.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@dexgs dexgs marked this pull request as draft July 20, 2024 18:26
@dexgs dexgs force-pushed the gamescope branch 10 times, most recently from 705bdc4 to 46c3343 Compare July 21, 2024 03:34
@dexgs dexgs marked this pull request as ready for review July 21, 2024 13:05
@classabbyamp
Copy link
Member

File Diff of gamescope:
--- REPO
+++ BUILT
@@ -2,0 +6,4 @@
+/usr/lib/libdisplay-info.a
+/usr/lib/libliftoff.a
+/usr/lib/libwlroots.a
+/usr/lib/pkgconfig/display-info.pc

should not include these

@dexgs
Copy link
Contributor Author

dexgs commented Jul 22, 2024

@classabbyamp ah yeah. Would it be acceptable to just remove everything from /usr/lib and /usr/include in destdir? Gamescope itself doesn't put anything there.

@classabbyamp
Copy link
Member

what about /usr/lib/libVkLayer_FROG_gamescope_wsi_x86_64.so?

@dexgs
Copy link
Contributor Author

dexgs commented Jul 22, 2024

the gamescope binary doesn't link against that shlib, and seems to work properly if it's missing, but i agree it's probably best to leave it

Co-authored-by: caitcat <caitcatdev@protonmail.com>
@classabbyamp classabbyamp merged commit e40aa41 into void-linux:master Jul 23, 2024
8 checks passed
@dexgs dexgs deleted the gamescope branch August 3, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants