Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elvish: update to 0.21.0. #52472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

elvish: update to 0.21.0. #52472

wants to merge 1 commit into from

Conversation

john-gold
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@john-gold
Copy link
Contributor Author

When running ./xbps-src check elvish the same tests fail as in the CI pipeline.

But running go test ./... locally in the elvish repository succeeds.

@john-gold john-gold force-pushed the elvish branch 4 times, most recently from 7789c92 to 2a2940e Compare October 6, 2024 16:15
@john-gold
Copy link
Contributor Author

Turns out these unit tests have been enabled with go build style just two months ago (with 332756e). Before that commit they have never been executed with this template.

I locally ran xbps-src check elvish with enabled unit tests in previous versions like 0.20.1 (2a2940e) and the same tests are failing. Therefore, I suspect that this problem has not been noticed until now because the tests were deactivated.

I suggest disabling the tests temporarily until a solution to the issue is found (as mentioned the test fail only when run via xbps-src.

@john-gold john-gold force-pushed the elvish branch 2 times, most recently from a742cf8 to 7128eb2 Compare October 10, 2024 06:41
@john-gold john-gold force-pushed the elvish branch 2 times, most recently from 047949f to bbd3d76 Compare October 14, 2024 05:58
@john-gold john-gold force-pushed the elvish branch 5 times, most recently from 9b88c4d to 6ca22ed Compare October 18, 2024 14:25
@classabbyamp classabbyamp mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classabbyamp classabbyamp classabbyamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-gold @classabbyamp