-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: mindustry-7.0_b146 #52749
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't vendor desktop files
@classabbyamp Yes I know but this would be quite unusable without them. P.S. |
a564274
to
4777bf0
Compare
Mindustries Readme specifies exactly openjdk17, not 17+. Maybe we should to reflect that in dependeency (and launch script). The i668*|*-musl broke sounds like gradle fetches a prebuilt libarc.so? So it will most likely also be broken on some cross builts?! |
https://github.com/Anuken/Arc/tree/master/natives/natives-desktop/libs The Arc repo has precompiled libs directly in their git repo. Arc's native libraries should be built from source. |
@Johnnynator do you know how the native libs should be built?
Yes, the build uses the libs that are in the repo.
Fixed Java dependency is HIGHLY unusual and works quite well here with openjdk21. |
gradle... jni... no, not really, I just know how stuff is broken, not how to fix :(.
They only provide a glibc x64 precompiled right no, so everything not |
@Johnnynator I'll see if I can build the native libs myself to support more :) Thanks! |
dd09313
to
3ba876f
Compare
1b762f9
to
9269b90
Compare
@Johnnynator I'm giving up on building Arc as it's not trivial and likely won't improve the situation much. Maybe one day they'll improve their setup. |
9269b90
to
d85684f
Compare
Testing the changes
New package
Local build testing
Solves #38019, #45582.