Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: mindustry-7.0_b146 #52749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MIvanchev
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (X86_64-GLIBC)

Solves #38019, #45582.

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't vendor desktop files

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 23, 2024
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Oct 23, 2024

@classabbyamp Yes I know but this would be quite unusable without them.

P.S.
I mean no, you're right, the scripts are enough to launch, I'll remove em.

@MIvanchev MIvanchev force-pushed the ci-mindustry branch 4 times, most recently from a564274 to 4777bf0 Compare October 23, 2024 12:28
@Johnnynator
Copy link
Member

Mindustries Readme specifies exactly openjdk17, not 17+. Maybe we should to reflect that in dependeency (and launch script).

The i668*|*-musl broke sounds like gradle fetches a prebuilt libarc.so? So it will most likely also be broken on some cross builts?!

@Johnnynator
Copy link
Member

Johnnynator commented Oct 23, 2024

https://github.com/Anuken/Arc/tree/master/natives/natives-desktop/libs

The Arc repo has precompiled libs directly in their git repo. Arc's native libraries should be built from source.

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Oct 23, 2024

@Johnnynator do you know how the native libs should be built?

The i668*|*-musl broke sounds like gradle fetches a prebuilt libarc.so? So it will most likely also be broken on some cross builts?!

Yes, the build uses the libs that are in the repo.

Mindustries Readme specifies exactly openjdk17, not 17+. Maybe we should to reflect that in dependeency (and launch script).

Fixed Java dependency is HIGHLY unusual and works quite well here with openjdk21.

@Johnnynator
Copy link
Member

@Johnnynator do you know how the native libs should be built?

gradle... jni... no, not really, I just know how stuff is broken, not how to fix :(.
And that gradle scripts of arc look like pain, using curl to fetch sources and other things.
These gradle build scripts assume a developer that wants to ship a .jar that works on x systems, not a Distro, that wants to build the .jar for a single arch and have a package manager that selects the correct jar to download (or bundle it into a package)

The i668*|*-musl broke sounds like gradle fetches a prebuilt libarc.so? So it will most likely also be broken on some cross builts?!

Yes, the build uses the libs that are in the repo.

They only provide a glibc x64 precompiled right no, so everything not x86_64 is 100% broken.

@Johnnynator
Copy link
Member

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/games/mindustry/default.nix#L165-L181

Nix does things

@MIvanchev
Copy link
Contributor Author

@Johnnynator I'll see if I can build the native libs myself to support more :) Thanks!

@MIvanchev MIvanchev force-pushed the ci-mindustry branch 2 times, most recently from dd09313 to 3ba876f Compare October 23, 2024 17:42
@MIvanchev MIvanchev changed the title New package: mindustry-7.0_b146 [WIP] New package: mindustry-7.0_b146 Oct 23, 2024
@MIvanchev MIvanchev force-pushed the ci-mindustry branch 6 times, most recently from 1b762f9 to 9269b90 Compare October 24, 2024 07:29
@MIvanchev
Copy link
Contributor Author

@Johnnynator I'm giving up on building Arc as it's not trivial and likely won't improve the situation much. Maybe one day they'll improve their setup.

@MIvanchev MIvanchev changed the title [WIP] New package: mindustry-7.0_b146 New package: mindustry-7.0_b146 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants