feat: resolve Vite+ executable paths from VpDirs - #131
Merged
Conversation
fengmk2
force-pushed
the
agent/xdg-directory-129
branch
from
August 19, 2026 03:39
1134178 to
c31c31c
Compare
fengmk2
commented
Aug 19, 2026
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 703e678316
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fengmk2
force-pushed
the
agent/xdg-directory-129
branch
from
August 20, 2026 12:09
c06cc0b to
511055c
Compare
fengmk2
marked this pull request as ready for review
August 20, 2026 12:12
Member
Author
|
Retested the rebased head
GitLab verification remains green after the shell-isolation change. |
Merged
fengmk2
added a commit
that referenced
this pull request
Aug 24, 2026
Bump `package.json`, README examples, and the GitLab and Azure template defaults to `v1.18.0`. Changes since `v1.17.0`: - Resolve Vite+ executable paths from `VpDirs` (#131). - Add GitLab end-to-end tests (#132). - Clarify automatic Node.js version selection (#130). - Pin the install script to the requested version (#127). - Update `pnpm/action-setup` to `v6.0.10` (#124). - Update `vite-plus` to `v0.2.9` (#125). After merge, create the annotated tag `v1.18.0` on the merge commit. Push the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action reads Vite+'s executable directory from the installed payload. Vite+ 0.3.0 prerelease builds and later versions use
VP_DUMP_DIRS=1.Preview builds also use this check. Versions before the 0.3 release line use the original installer command and the legacy executable directory.
GitHub Actions, Azure Pipelines, and GitLab use the same version check.
Closes #129.