Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't need gen-code anymore in this repo's code #2891

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't need gen-code anymore in this repo's code #2891

wants to merge 1 commit into from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 31, 2023 •
edited
Loading

Fix #2878, as it describes, it will generate codes in apis dir when run make verify at local env. Remove it from code becualse code-generate is move to apis repo.

/kind clean-up

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2023
@lowang-bh lowang-bh changed the title no apis in scheduler code, no need to gen-code don't need gen-code anymore May 31, 2023
@lowang-bh lowang-bh changed the title don't need gen-code anymore don't need gen-code anymore in this repo's code May 31, 2023
@lowang-bh
Copy link
Member Author

trigger ci

@lowang-bh lowang-bh closed this May 31, 2023
@lowang-bh lowang-bh reopened this May 31, 2023
hwdef
hwdef reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this solution is related to issue.
Don't we need verify gencode?

@lowang-bh
Copy link
Member Author

lowang-bh commented Jun 1, 2023 •
edited
Loading

I don't understand how this solution is related to issue. Don't we need verify gencode?

Becasue we are use apis in https://github.com/volcano-sh/apis, it doesn't need here any more.
The latest gen-code script is at https://github.com/volcano-sh/apis/blob/master/hack/update-codegen.sh.
Maybe we also need to remove hack/update-codegen.sh from this source code.

hwdef
hwdef reviewed Jun 1, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
hwdef
hwdef reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@william-wang
Copy link
Member

@lowang-bh please help to solve the confliction:)

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lowang-bh
Copy link
Member Author

@lowang-bh please help to solve the confliction:)

Done.

@lowang-bh
Copy link
Member Author

/assign @hwdef @william-wang @Thor-wl

hwdef
hwdef reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@volcano-sh-bot
Copy link
Contributor

@lowang-bh: The label(s) kind/clean-up cannot be applied. These labels are supported: ``

In response to this:

Fix #2878, as it describes, it will generate codes in apis dir when run make verify at local env. Remove it from code becualse code-generate is move to apis repo.

/kind clean-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Oct 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2023
@lowang-bh
Copy link
Member Author

/remove lifecycle

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2023
@lowang-bh
Copy link
Member Author

/assign @Monokaix

@hwdef hwdef removed their assignment Jan 25, 2024
@Monokaix
Copy link
Member

Please resolve code confliction.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Monokaix
Copy link
Member

Monokaix commented Feb 1, 2024 •
edited
Loading

It occurs to me that we have a plan to move api repo to volcano staging dir, because these two repoes are closely linked. So I think move api to current repo is more meaningful, and then we will need this script.

If anyone is interested, welcome to contribute.

Related issue: #2356

@lowang-bh
no apis in scheduler code, no need to gen-code
a614955 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2024
@volcano-sh-bot
Copy link
Contributor

@lowang-bh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@merryzhou merryzhou Awaiting requested review from merryzhou

At least 1 approving review is required to merge this pull request.

Assignees

@william-wang william-wang

@Monokaix Monokaix

@Thor-wl Thor-wl

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clientset does not implement clientset.Interface
6 participants
@lowang-bh @william-wang @volcano-sh-bot @Monokaix @hwdef @Thor-wl