this is a safe evict , making descheduler more powerful #2974
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XS
|
@gj199575 Please log a issue firstly and describe your requirement and by the way please use english so that all the contributor can get into the discussion. |
gj409237405
changed the title
ok |
Signed-off-by: gj199575 <409237405@qq.com>
volcano-sh-bot
added
size/M
| @@ -161,7 +162,14 @@ func (db *DefaultBinder) Bind(kubeClient kubernetes.Interface, tasks []*scheduli | |||
| var errTasks []*schedulingapi.TaskInfo | |||
| for _, task := range tasks { | |||
| p := task.Pod | |||
| if err := kubeClient.CoreV1().Pods(p.Namespace).Bind(context.TODO(), | |||
| if p.Annotations["is-fake"] == "true" { | |||
There was a problem hiding this comment.
I'm sorry for not get the usage of is-fake annotation, can you add more description about this PR?
| if p.Annotations["is-fake"] == "true" { | ||
| db.CreateQueue() | ||
| p.Annotations["fake-pod"] = task.NodeName | ||
| p.Annotations["scheduling.k8s.io/group-name"] = "job1-e7f18111-1cec-11ea-b688-fa163ec79500" |
There was a problem hiding this comment.
Why this is a hard-code annotation with key 'group-name'?
|
I'm sorry that I cannot merge this PR for there are serious problems both in issue description and code. |
Thor-wl
added
the
do-not-merge/hold
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
lifecycle/stale
this is a safe evict , making descheduler more powerful
descheduler pr:kubernetes-sigs/descheduler#1188