-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor buildPod in unit test #2982
♻️ refactor buildPod in unit test #2982
Conversation
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
/hold |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
what should do to move it forward |
still need |
1 similar comment
still need |
Because the origin PR has two much different and conflicts with the latest master, So I decided to reopen a new PR #3251 |
on the base of #2901
I found that the function
BuildPod
,BuildPodWithPVC
,BuildBestEffortPod
,BuildPodWithPriority
have many dumplicate code, which could be refactor useOption
code model.NOTE: #2901 should be merged firstly.