-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports rollback when allocate callback function fails #3776
Supports rollback when allocate callback function fails #3776
Conversation
… executed, for example, in the GPU allocation scenario Signed-off-by: wangyang0616 <wangyang8126@gmail.com>
906efb6
to
e91123f
Compare
Signed-off-by: wangyang <wangyang8126@gmail.com>
e91123f
to
566f751
Compare
} | ||
} | ||
return fmt.Errorf("Failed to exec allocate callback functions") | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about aggregate errs and call unallocate
func when there is err?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When each pod allocation is successful, but the overall vcjob does not meet expectations, unallocate
is used to roll back the previous resource scheduling information.
For direct resource errors and exceptions during the scheduling process, I understand that it would be more appropriate to roll back directly based on the error.
Signed-off-by: wangyang0616 <wangyang8126@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix issue #3777 for task 1