Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the default nodeSelector value from the volcano monitoring installation yaml. #3781

Merged

Conversation

fengruotj
Copy link
Contributor

@fengruotj fengruotj commented Oct 18, 2024

Fix #3779.

we can remove the nodeSelector default value from the volcano/installer/volcano-monitoring-latest.yaml file. If we want setting volcano-monitoring nodeSelector, we can run the helm chart with Values.custom.metrics_enable & Values.custom.kube_state_metrics_ns.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
@fengruotj fengruotj changed the title fix: remove the default nodeSelector value from the volcano monitorin… fix: remove the default nodeSelector value from the volcano monitoring installation yaml. Oct 18, 2024
@fengruotj fengruotj force-pushed the fix-volcano-monitoring-latest-yaml branch from 58150e2 to 2c7c266 Compare October 18, 2024 02:42
@fengruotj
Copy link
Contributor Author

If we use helm-chart command, we can use --set custom.metrics_enable=true --set custom.kube_state_metrics_ns."\node\.kubernetes\.io/instance-type"=controlpanel to set the default value.

@Monokaix
Copy link
Member

We can exec make generate-yaml TAG=latest RELEASE_DIR=installer to modify the installer/volcano-monitoring-latest.yaml.

@fengruotj
Copy link
Contributor Author

fengruotj commented Oct 18, 2024

We can exec make generate-yaml TAG=latest RELEASE_DIR=installer to modify the installer/volcano-monitoring-latest.yaml.

ok. It means that this is not an issue?

@Monokaix
Copy link
Member

We can exec make generate-yaml TAG=latest RELEASE_DIR=installer to modify the installer/volcano-monitoring-latest.yaml.

ok. It means that this is not an issue?

No,I mean you can exec it and the file will be modified automatically and then commit the changes: )

@Monokaix
Copy link
Member

Please also sign off your commit with git -s.

@fengruotj fengruotj force-pushed the fix-volcano-monitoring-latest-yaml branch from 2c7c266 to 4c0ffb3 Compare October 18, 2024 08:37
@fengruotj fengruotj closed this Oct 18, 2024
@fengruotj fengruotj reopened this Oct 18, 2024
@fengruotj
Copy link
Contributor Author

Please also sign off your commit with git -s.

I've already signed off my commit wiht git commit -s. Thanks you very much~

@fengruotj
Copy link
Contributor Author

We can exec make generate-yaml TAG=latest RELEASE_DIR=installer to modify the installer/volcano-monitoring-latest.yaml.

ok. It means that this is not an issue?

No,I mean you can exec it and the file will be modified automatically and then commit the changes: )

Thanks, I've already done.

…g installation yaml.

Signed-off-by: tanjie.master <tanjiemaster@gmail.com>
@fengruotj fengruotj force-pushed the fix-volcano-monitoring-latest-yaml branch from 4c0ffb3 to 977bd7d Compare October 18, 2024 09:04
@fengruotj
Copy link
Contributor Author

fengruotj commented Oct 18, 2024

/assign @Monokaix @shinytang6 @hwdef

@Monokaix
Copy link
Member

/ok-to-test
/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Oct 18, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@volcano-sh-bot volcano-sh-bot merged commit 4773047 into volcano-sh:master Oct 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-yaml volcano-monitoring-latest.yaml diffrent
3 participants