-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the default nodeSelector value from the volcano monitoring installation yaml. #3781
fix: remove the default nodeSelector value from the volcano monitoring installation yaml. #3781
Conversation
58150e2
to
2c7c266
Compare
If we use helm-chart command, we can use |
We can exec |
ok. It means that this is not an issue? |
No,I mean you can exec it and the file will be modified automatically and then commit the changes: ) |
Please also sign off your commit with |
2c7c266
to
4c0ffb3
Compare
I've already signed off my commit wiht git commit -s. Thanks you very much~ |
Thanks, I've already done. |
…g installation yaml. Signed-off-by: tanjie.master <tanjiemaster@gmail.com>
4c0ffb3
to
977bd7d
Compare
/assign @Monokaix @shinytang6 @hwdef |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #3779.
we can remove the nodeSelector default value from the volcano/installer/volcano-monitoring-latest.yaml file. If we want setting volcano-monitoring nodeSelector, we can run the helm chart with Values.custom.metrics_enable & Values.custom.kube_state_metrics_ns.