-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the volcano metric document. #3782
base: master
Are you sure you want to change the base?
Conversation
I've already update the volcano metric document by |
/assign @Monokaix |
docs/design/metrics.md
Outdated
| unschedule_task_count | Counter | `job`=<job_id> | The number of tasks failed to schedule | | ||
| unschedule_job_counts | Counter | | The number of job failed to schedule in each iteration | | ||
| job_retry_counts | Counter | `job`=<job_id> | The number of retry times of one job | | ||
| **Metric Name** | **Metric Type** | **Labels** | **Description** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are pod_schedule_errors
and pod_schedule_successes
deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I've not found the metrics, like pod_schedule_errors
and pod_schedule_successes
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, volcano uses the schedule_attempts_total
counter metrics.
docs/design/metrics.md
Outdated
@@ -1,39 +1,40 @@ | |||
## Scheduler Monitoring | |||
|
|||
## Introduction | |||
Currently users can leverage controller logs and job events to monitor scheduler. While useful for debugging, none of this options is particularly practical for monitoring kube-batch behaviour over time. There's also requirement like to monitor kube-batch in one view to resolve critical performance issue in time [#427](https://github.com/kubernetes-sigs/kube-batch/issues/427). | |||
Currently users can leverage controller logs and job events to monitor scheduler. While useful for debugging, none of this options is particularly practical for monitoring volcano behaviour over time. There's also requirement like to monitor volcano in one view to resolve critical performance issue in time [#427](https://github.com/kubernetes-sigs/volcano/issues/427). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the issue link need not to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've already fix it. In addition, I add more metrics defination.
dbdfc8e
to
7f23e59
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58f0921
to
d40ef51
Compare
Could you also add metrics with these PR? #3650 |
Signed-off-by: tanjie.master <tanjiemaster@gmail.com>
d40ef51
to
c8012c7
Compare
|
Yes, I've already added it. |
/ok-to-test |
cc @hwdef @lowang-bh |
fix: the metric doc lacks updates Issue 3118