-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support colocation for computing workload and mircro-service #3784
Conversation
Signed-off-by: Marty Mcfly <2536818783@qq.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/networkqos/networkqos.go
Outdated
} | ||
} | ||
|
||
onlineBandwidthWatermark, err = GetOnlineBandwidthWatermark(int(m.flavorQuotaMinRate), qosConf) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
pkg/networkqos/networkqos.go
Outdated
return "", "", "", fmt.Errorf("failed to get onlineBandwidthWatermark, err: %v", err) | ||
} | ||
|
||
offlineLowBandwidth, err = GetOfflineLowBandwidthPercent(int(m.flavorQuotaMinRate), qosConf) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
pkg/networkqos/networkqos.go
Outdated
return "", "", "", fmt.Errorf("failed to get offlineLowBandwidth, err: %v", err) | ||
} | ||
|
||
offlineHighBandwidth, err = GetOfflineHighBandwidthPercent(int(m.flavorQuotaMinRate), qosConf) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
d38749e
to
3db4361
Compare
/reopen |
@william-wang: Failed to re-open PR: state cannot be changed. The colocation branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Implement for #3783