Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support colocation for computing workload and mircro-service #3784

Closed
wants to merge 2 commits into from
Closed

Support colocation for computing workload and mircro-service #3784

wants to merge 2 commits into from

Conversation

william-wang
Copy link
Member

Implement for #3783

gaofei and others added 2 commits June 11, 2024 14:30
first commit
631f0af
@Monokaix @gitee-org
add LICENSE.
3db4361 
Signed-off-by: Marty Mcfly <2536818783@qq.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 21, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2024
View reviewed changes
pkg/networkqos/networkqos.go Outdated
}
}

onlineBandwidthWatermark, err = GetOnlineBandwidthWatermark(int(m.flavorQuotaMinRate), qosConf)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a signed 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
pkg/networkqos/networkqos.go Outdated
return "", "", "", fmt.Errorf("failed to get onlineBandwidthWatermark, err: %v", err)
}

offlineLowBandwidth, err = GetOfflineLowBandwidthPercent(int(m.flavorQuotaMinRate), qosConf)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a signed 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
pkg/networkqos/networkqos.go Outdated
return "", "", "", fmt.Errorf("failed to get offlineLowBandwidth, err: %v", err)
}

offlineHighBandwidth, err = GetOfflineHighBandwidthPercent(int(m.flavorQuotaMinRate), qosConf)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a signed 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2024
@william-wang
Copy link
Member Author

/reopen

@volcano-sh-bot
Copy link
Contributor

@william-wang: Failed to re-open PR: state cannot be changed. The colocation branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Awaiting requested review from Monokaix

@wangyang0616 wangyang0616 Awaiting requested review from wangyang0616

Assignees
No one assigned
Labels
retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@william-wang @volcano-sh-bot @Monokaix