fix(bench): include file open in random-access reopen timings - #9631
Draft
lwwmanning wants to merge 1 commit into
Draft
fix(bench): include file open in random-access reopen timings#9631lwwmanning wants to merge 1 commit into
lwwmanning wants to merge 1 commit into
Conversation
Signed-off-by: Will Manning <will@willmanning.io>
Merging this PR will improve performance by 21.99%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.4 µs | 12.6 µs | +62.12% |
| ⚡ | Simulation | compact[(2048, 90)] |
1.5 µs | 1.4 µs | +11.89% |
| ⚡ | Simulation | compress_fsst[(500, 64, 4)] |
488.1 µs | 441.6 µs | +10.52% |
| ⚡ | Simulation | compress_fsst[(500, 64, 8)] |
524.9 µs | 475.1 µs | +10.48% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wm/random-access-reopen-timing (e003545) with develop (ee1ac25)
Footnotes
-
106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
joseph-isaacs
added
the
action/bench-random-access
github-actions
Bot
removed
the
action/bench-random-access
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Random Access 📖Commits: PR How to read Verdict and Engines
random-access / vortex-file-compressed / ns (1.281x ❌, 0↑ 10↓)
random-access / parquet / ns (1.002x ➖, 0↑ 0↓)
random-access / lance / ns (1.104x ❌, 0↑ 8↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--open-mode reopencreates each accessor outside the recorded timing interval. Its-footermeasurements therefore exclude file-open and metadata parsing costs.Changes
Create the accessor inside each timed reopen iteration. Cached mode still opens once and reuses its accessor.
🤖 Generated with Claude Code