Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow scanning official ballots in test mode per system setting in VxCentralScan #5537

Merged
merged 1 commit into from
Oct 17, 2024
Merged

allow scanning official ballots in test mode per system setting in VxCentralScan #5537

merged 1 commit into from
Oct 17, 2024

Conversation

adghayes
Copy link
Collaborator

Overview

Closes #5528.

jonahkagan
jonahkagan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jonahkagan jonahkagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test?

@adghayes
Copy link
Collaborator Author

I didn't add one because we have testing in ballot-interpreter and no testing in apps/scan, so mirrored that in apps/central-scan. We should probably have testing in both the apps but I'm not going to prioritize that now.

@adghayes adghayes merged commit 8459d5a into main Oct 17, 2024
62 checks passed
@adghayes adghayes deleted the drew/central-scan-official branch October 17, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahkagan jonahkagan jonahkagan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowOfficialBallotsInTestMode is not handled by central-scan
2 participants
@adghayes @jonahkagan