Remove support for providers yum, zypper #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
May 10, 2019
|
This package https://software.opensuse.org/download.html?project=systemsmanagement%3Apuppet&package=rubygem-r10k isn't that old... |
|
@alexjfisher Hm. I missed that somehow and will drop the latest commit. Interesting that SLES provides a package and RHEL does not. Usually it is the other way around. |
|
r10k 2.3.0 was released on May 18, 2016 (current is 3.2.0 from April 16, 2019), so I'm not sure that I would say the packages are anything near recent, even if the timestamps are. |
|
Someone needs to make a decision. I still think we should remove yum and zypper, because it does not hurt to install a gem. |
|
let's keep it open for 3 more days. I'm 👍 for dropping it. If nobody offers an argument to keep it, we can drop it. |
dhoppe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for providers
yumandzypper. We also might want to remove support for OpenBSD and remove thepackageresource, since this was introduced for Puppet Enterprise which hasr10kalready installed.This will fix issue #449.