modulesync 7.2.0 #198
Merged
modulesync 7.2.0 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
modulesync
branch
2 times, most recently
from
cc6e4fd
to
0d56a5b
Compare
|
Well, this is a bug in beaker_puppet_helpers with quoting: |
|
voxpupuli/beaker_puppet_helpers#40 should fix that. |
ekohl
reviewed
Jan 9, 2024
spec/spec_helper_acceptance.rb
Outdated
| install_module_from_forge('puppet-epel', '>= 3.0.1 < 4.0.0') if fact_on(host, 'os.name') == 'CentOS' | ||
| install_module_from_forge('puppetlabs-apache', '>= 5.7.0 < 7.0.0') | ||
| install_module_from_forge('puppetlabs-java', '>= 6.3.0 < 8.0.0') | ||
| install_puppet_module_via_pmt_on(host, 'puppet-epel', '>= 3.0.1 < 4.0.0') if fact_on(host, 'os.name') == 'CentOS' |
There was a problem hiding this comment.
OracleLinux is failing because it's not installing the EPEL module here. That was also an issue previously, so it's not a regression. Just wondering how this ever worked.
There was a problem hiding this comment.
there's a high chance that when the tests passed the last time, acceptance tests weren't enabled for OracleLinux?
ekohl
approved these changes
Jan 9, 2024
While running acceptance tests it proved that it couldn't install.
|
Now includes #204 to drop OracleLinux, since it failed in testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.