Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI only when changes (additions) to a subdir are made #19

Merged
merged 33 commits into from
Jul 26, 2023
Merged

Trigger CI only when changes (additions) to a subdir are made #19

merged 33 commits into from
Jul 26, 2023

Conversation

garciagenrique
Copy link
Member

@garciagenrique garciagenrique commented Jul 24, 2023 •
edited
Loading

Environments are built only when changes to a subdirectory are made. The github actions file, changes to the . directory of this repo and any changes to any README.md files won't trigger the building of the images.

fixes #16
Creates Issue #21

@garciagenrique garciagenrique force-pushed the issue16_trigger_ci_only_changes branch from 60ec5de to 6feff8b Compare July 24, 2023 11:44
@garciagenrique garciagenrique force-pushed the issue16_trigger_ci_only_changes branch from 85c91df to 2ad97c8 Compare July 24, 2023 12:23
@garciagenrique garciagenrique changed the title WIP: test files changes dirs Trigger CI only when changes (additions) to a subdir are made Jul 26, 2023
goseind
goseind approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@goseind goseind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat! Great job with the output, then used as the matrix! 🚀
It looks fine to me, haven't tested it myself, but I assume you did, and it works, so good to go!

Maybe consider a squash merge because of all the commits for testing.

@goseind goseind added cern-vre-infra Things only related and depandant on our team component/images Container images for jhub profiles labels Jul 26, 2023
@garciagenrique
Copy link
Member Author

Maybe consider a squash merge because of all the commits for testing.

Sure ! Almost always doing this :D

@garciagenrique garciagenrique merged commit c281b19 into main Jul 26, 2023
@garciagenrique garciagenrique deleted the issue16_trigger_ci_only_changes branch July 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goseind goseind goseind approved these changes

Assignees

@garciagenrique garciagenrique

Labels
cern-vre-infra Things only related and depandant on our team component/images Container images for jhub profiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid building all the images every time a new env is added
2 participants
@garciagenrique @goseind