Merge pull request #177 from vtex-apps/fix/dm-days

Fixed Process Conversions multiple days
vtex-apps · Jul 23, 2024 · 52d1f3b · 52d1f3b
2 parents 5714008 + 2fbe1ab
commit 52d1f3b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+- Process Conversions multiple days
+
 ## [1.24.0] - 2024-07-23
 
 ### Added

diff --git a/dotnet/Services/VtexApiService.cs b/dotnet/Services/VtexApiService.cs
@@ -1056,16 +1056,26 @@ public async Task<string> ProcessConversions(int days)
             try
             {
                 StringBuilder sb = new StringBuilder();
-                DateTime dtStartTime = DateTime.Now.AddDays(-days);
-                DateTime dtEndTime = DateTime.Now;
-                ConversionReportResponse conversionReport = await _cybersourceApi.ConversionDetailReport(dtStartTime, dtEndTime);
-                if (conversionReport != null)
+                if(days <= 0)
                 {
-                    foreach (ConversionDetail conversionDetail in conversionReport.ConversionDetails)
+                    days = 1;
+                }
+
+                while (days > 0)
+                {
+                    DateTime dtStartTime = DateTime.Now.AddDays(-days);
+                    DateTime dtEndTime = DateTime.Now.AddDays(-(days-1));
+                    ConversionReportResponse conversionReport = await _cybersourceApi.ConversionDetailReport(dtStartTime, dtEndTime);
+                    if (conversionReport != null)
                     {
-                        //sb.AppendLine($"{conversionDetail.MerchantReferenceNumber} {conversionDetail.OriginalDecision} - {conversionDetail.NewDecision} ");
-                        sb.AppendLine(await this.UpdateOrderStatus(conversionDetail.MerchantReferenceNumber, conversionDetail.NewDecision, conversionDetail.ReviewerComments));
+                        foreach (ConversionDetail conversionDetail in conversionReport.ConversionDetails)
+                        {
+                            //sb.AppendLine($"{conversionDetail.MerchantReferenceNumber} {conversionDetail.OriginalDecision} - {conversionDetail.NewDecision} ");
+                            sb.AppendLine(await this.UpdateOrderStatus(conversionDetail.MerchantReferenceNumber, conversionDetail.NewDecision, conversionDetail.ReviewerComments));
+                        }
                     }
+
+                    days--;
                 }
 
                 results = sb.ToString();