Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow two digit country codes #172

Merged
merged 1 commit into from
Jun 25, 2024
Merged

allow two digit country codes #172

merged 1 commit into from
Jun 25, 2024

Conversation

btalma
Copy link
Contributor

@btalma btalma commented Jun 25, 2024

If country is three characters, convert to two. If two, assume the code is correct. If not 2 or 3, return empty string

Copy link

vtex-io-ci-cd bot commented Jun 25, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 11, PR deletions = 1

Generated by 🚫 dangerJS against 9094940

@jorgeAcostaVTEX jorgeAcostaVTEX self-requested a review June 25, 2024 15:50
Copy link

@jorgeAcostaVTEX jorgeAcostaVTEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btalma btalma merged commit 802fe80 into master Jun 25, 2024
11 of 12 checks passed
@btalma btalma deleted the fix/country-code branch June 25, 2024 16:01
Copy link

vtex-io-ci-cd bot commented Jun 25, 2024

Your PR has been merged! App is being published. 🚀
Version 1.22.0 → 1.22.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.cybersource@1.22.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants