Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make settings vary by binding #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jgfidelis
Copy link
Contributor

@jgfidelis jgfidelis commented Jun 25, 2020

What problem is this solving?

Make possible of vtex.store settings to vary by binding

How to test it?

https://binding--boticario.myvtex.com/admin/cms/store

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@jgfidelis jgfidelis requested a review from a team as a code owner June 25, 2020 22:21
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 25, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@Klynger Klynger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workspace?

@Klynger
Copy link
Contributor

Klynger commented Jun 26, 2020

I imagine that it solves https://github.com/vtex-apps/store-discussion/discussions/269

@jgfidelis jgfidelis requested a review from Klynger June 29, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants