Action bar - order and payment [last subscription cycle]

[rrbambokian]

What does this PR do? *

New action bar behaviors for the last subscription's cycle.

How to test it? *

• Login in workspace
• Visit a specific subscription details screen
• Then, check 'contextual primary actions' section on Figma layout and compare with the orders and payments action bar present in the workspace

Related to / Depends on *

[salesfelipe]

Maybe passing the full order to this guy is a better approach instead of multiple props.

[rrbambokian]

checking DetailsPage, the ActionBar is called like this:

<ActionBar
  status={subscription.status}
  isSkipped={subscription.isSkipped}
  address={subscription.shippingAddress}
  payment={subscription.purchaseSettings.paymentMethod}
  onUpdateAction={this.handleUpdateAction}
  nextPurchaseDate={subscription.nextPurchaseDate}
  orderStatus={subscription.lastExecution?.order?.status}
  orderDeliveryDate={
    subscription.lastExecution?.order?.status === 'invoiced'
      ? orderLogisticsInfo.length > 0 &&
        orderLogisticsInfo[0].shippingEstimateDate
      : undefined
  }
  orderTrackingUrl={
    subscription.lastExecution?.order?.status === 'invoiced'
      ? orderPackages.length > 0 && orderPackages[0].trackingUrl
      : undefined
  }
  bankSlipUrl={orderTransactions?.[0].payments?.[0]?.url}
/>

there are conditions in some parameters.. do you think it's better this way or passes the entire subscription object to handle it inside the action bar?

[salesfelipe]

Displaying an anchor tag is a better approach instead of calling through javascript and you can do it on the ActionBar component itself instead of doing it on the parent component

[rrbambokian]

hmm I get it.. but based on the generic structure defined in this handleUpdateAction method, that the effects are generated from the action param, isn't it preferable to keep the navigations that way?

[salesfelipe]

What does this do?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication