Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft of clarity and concision pass on sections 2.1 through 2.5 #136

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Dec 17, 2021

This is part of #107

I'm doing it in chunks to prevent horrible merge conflicts and to actually make progress


Preview | Diff


<div class=example>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got rid of this example bc i think it doesn't seem to be demonstrating how persistent storage can be abused (it seems to be demonstrating how service workers can be abused, whether or not they persist across sessions

@pes10k pes10k requested a review from hober December 17, 2021 21:40
Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of nits. Otherwise this looks great! Merge away once you've fixed the nits!

index.bs Outdated
when doing so is necessary to serve a clear user need.
Does your feature expose information to origins?
If so, how does exposing this information serve user needs?
Does your feature expose information to wbe sites?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look, if you're going to expect me to spell everything correctly, we're going to be at this for a long time :P

index.bs Outdated
</h3>

Personal information is any data about a user
(for example, their home address),
or information that could be used to identify a user,
such as an alias, email address, or identification number.

Note: Personal information is
Personal information is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay in a Note block.

@pes10k pes10k merged commit c54ad08 into main Jan 6, 2022
@pes10k pes10k deleted the tidy-pass-on-2.1--2.5 branch January 6, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants