Merge pull request #1106 from wakatime/bugfix/nested-status-code-less…

…-strict Support nested heartbeat response status in 2xx range
wakatime · Oct 8, 2024 · 660b2b9 · 660b2b9
2 parents d32ccc3 + 3d05897
commit 660b2b9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/api/heartbeat.go b/pkg/api/heartbeat.go
@@ -135,7 +135,7 @@ func parseHeartbeatResponse(data []json.RawMessage) (heartbeat.Result, error) {
 		return heartbeat.Result{}, fmt.Errorf("failed to parse json status: %s", err)
 	}
 
-	if result.Status >= http.StatusBadRequest {
+	if result.Status < http.StatusOK || result.Status > 299 {
 		resultErrors, err := parseHeartbeatResponseError(data[0])
 		if err != nil {
 			return heartbeat.Result{}, fmt.Errorf("failed to parse result errors: %s", err)

diff --git a/pkg/offline/offline.go b/pkg/offline/offline.go
@@ -218,8 +218,7 @@ func handleResults(filepath string, results []heartbeat.Result, hh []heartbeat.H
 			continue
 		}
 
-		if result.Status != http.StatusCreated &&
-			result.Status != http.StatusAccepted {
+		if result.Status < http.StatusOK || result.Status > 299 {
 			withInvalidStatus = append(withInvalidStatus, hh[n])
 		}
 	}