feat: Create api key secret in all namespaces (#59)

wandb · Jan 23, 2024 · 9ad644e · 9ad644e
1 parent fa2abd2
commit 9ad644e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/charts/launch-agent/Chart.yaml b/charts/launch-agent/Chart.yaml
@@ -3,7 +3,7 @@ name: launch-agent
 icon: https://em-content.zobj.net/thumbs/240/apple/354/rocket_1f680.png
 description: A Helm chart for running the W&B Launch Agent in Kubernetes
 type: application
-version: 0.11.6
+version: 0.11.7
 maintainers:
   - name: wandb
     email: support@wandb.com

diff --git a/charts/launch-agent/templates/deployment.yaml b/charts/launch-agent/templates/deployment.yaml
@@ -55,6 +55,8 @@ spec:
               value: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
             - name: WANDB_LAUNCH_START_TIMEOUT
               value: "{{ .Values.agent.startTimeout }}"
+            - name: WANDB_RELEASE_NAME
+              value: "{{ .Release.Name }}"
           volumeMounts:
             - name: wandb-launch-config
               mountPath: /home/launch_agent/.config/wandb

diff --git a/charts/launch-agent/templates/secret.yaml b/charts/launch-agent/templates/secret.yaml
@@ -1,16 +1,22 @@
 {{- if not .Values.agent.useExternalWandbSecret }}
+{{- $root := . -}}
+{{- $unique := uniq (append .Values.additionalTargetNamespaces .Values.namespace) }}
+{{- range $ns := $unique }}
 ---
 apiVersion: v1
 kind: Secret
 metadata:
-  name: wandb-api-key-{{ .Release.Name }}
-  namespace: {{ .Values.namespace }}
+  name: wandb-api-key-{{ $root.Release.Name }}
+  namespace: {{ $ns }}
+  labels:
+    wandb.ai/created-by: helm-chart
 type: kubernetes.io/basic-auth
 stringData:
-  password: {{ required "Please set agent.apiKey to a W&B API key" .Values.agent.apiKey }}
+  password: {{ required "Please set agent.apiKey to a W&B API key" $root.Values.agent.apiKey }}
 ...
 {{ end }}
 
+{{- end }}
 {{- if .Values.gitCreds }}
 ---
 apiVersion: v1