update deployment.tpl and service account

wandb · Oct 30, 2024 · a42e3c7 · a42e3c7
1 parent 42a8486
commit a42e3c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/charts/operator-wandb/charts/app/templates/_deployment.tpl b/charts/operator-wandb/charts/app/templates/_deployment.tpl
@@ -258,7 +258,7 @@ spec:
             - name: GORILLA_INTERNAL_JWT_ISSUERS
               value: '["https://kubernetes.default.svc.cluster.local"]'
             - name: GORILLA_INTERNAL_JWT_SUBJECTS
-              value: '["system:serviceaccount:default:{{ .Values.global.weave-trace.serviceAccountName }}"]'
+              value: '["system:serviceaccount:default:{{ index .Values.global \"weave-trace\" \"serviceAccountName\" }}"]'
             {{- end }}
             {{- include "app.extraEnv" (dict "global" $.Values.global "local" .Values) | nindent 12 }}
             {{- include "wandb.extraEnvFrom" (dict "root" $ "local" .) | nindent 12 }}

diff --git a/charts/operator-wandb/charts/weave-trace/templates/serviceaccount.yaml b/charts/operator-wandb/charts/weave-trace/templates/serviceaccount.yaml
@@ -1,4 +1,7 @@
 {{- if .Values.serviceAccount.create -}}
+{{- if (empty .Values.global.weave-trace.serviceAccountName) -}}
+{{- fail "Values.global.weave-trace.serviceAccountName cannot be empty if serviceAccount.create is true" -}}
+{{- end -}}
 apiVersion: v1
 kind: ServiceAccount
 metadata: