Skip to content

Commit

Permalink
chore: dont create managed cert in charts for google (#85)
Browse files Browse the repository at this point in the history
  • Loading branch information
adityachoudhari26 authored Mar 1, 2024
1 parent 875bb9c commit e5c061f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 22 deletions.
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.10.44
version: 0.10.45
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
21 changes: 0 additions & 21 deletions charts/operator-wandb/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
{{- if .Values.ingress.issuer.create }}
{{- if eq .Values.ingress.issuer.provider "google" }}
---
apiVersion: networking.gke.io/v1
kind: ManagedCertificate
metadata:
name: {{ .Release.Name }}-cert
namespace: {{ .Release.Namespace }}
labels:
{{- include "wandb.commonLabels" . | nindent 4 }}
spec:
domains:
- {{ replace "https://" "" (replace "http://" "" .Values.global.host) }}
{{- else }}
---
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
Expand All @@ -34,7 +20,6 @@ spec:
ingress:
class: {{ .Values.ingress.class }}
{{- end }}
{{- end }}
---
apiVersion: networking.k8s.io/v1
kind: Ingress
Expand All @@ -47,12 +32,8 @@ metadata:
{{- end }}
annotations:
{{- if .Values.ingress.issuer.create }}
{{- if eq .Values.ingress.issuer.provider "google" }}
"networking.gke.io/managed-certificates" : "{{ .Release.Name }}-cert"
{{- else }}
"cert-manager.io/issuer": "{{ .Release.Name }}-issuer"
"cert-manager.io/acme-challenge-type": "http01"
{{- end }}
"kubernetes.io/ingress.allow-http" : "false"
{{- end }}

Expand All @@ -64,11 +45,9 @@ spec:
{{- $defaultHost := include "defaultHost" . -}}

{{- if .Values.ingress.issuer.create }}
{{- if ne .Values.ingress.issuer.provider "google" }}
tls:
- host: [{{ $defaultHost }}]
secretName: {{ .Release.Name }}-tls
{{- end }}
{{- else }}
tls: {{ toYaml .Values.ingress.tls | nindent 4 }}
{{- end }}
Expand Down

0 comments on commit e5c061f

Please sign in to comment.