fix: Properly set namespace for deployments

wandb · Aug 23, 2023 · 53f51a9 · 53f51a9
1 parent 6af81bc
commit 53f51a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/controllers/weightsandbiases_controller.go b/controllers/weightsandbiases_controller.go
@@ -169,11 +169,12 @@ func (r *WeightsAndBiasesReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 		if err := specManager.SetActive(desiredSpec); err != nil {
 			r.Recorder.Event(wandb, corev1.EventTypeNormal, "SetActiveFailed", "Failed to save active state")
-			log.Error(err, "Failed to save active sucessful spec.")
+			log.Error(err, "Failed to save active successful spec.")
 			return ctrlqueue.DoNotRequeue()
 		}
 		log.Info("Successfully saved active spec")
 
+		r.Recorder.Event(wandb, corev1.EventTypeNormal, "Completed", "Completed reconcile successfully")
 		statusManager.Set(status.Completed)
 		return ctrlqueue.RequeueWithDelay(ctrlqueue.CheckForUpdatesFrequency)
 	}

diff --git a/pkg/helm/chart.go b/pkg/helm/chart.go
@@ -25,6 +25,7 @@ var (
 // where to store the versions
 func InitConfig(namespace string) (*cli.EnvSettings, *action.Configuration, error) {
 	settings := cli.New()
+	settings.SetNamespace(namespace)
 	config := new(action.Configuration)
 	err := config.Init(
 		settings.RESTClientGetter(),