fix: Support performance insights existing kms key arn (#115)

* chore: Add support for out of band Performance Insight's being added * null check on performance_insights_kms_key_arn
wandb · Jul 28, 2023 · 9385c01 · 9385c01
1 parent 0a6665e
commit 9385c01
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/main.tf b/main.tf
@@ -75,7 +75,7 @@ module "database" {
 
   namespace                        = var.namespace
   kms_key_arn                      = local.kms_key_arn
-  performance_insights_kms_key_arn = var.database_performance_insights_kms_key_arn_kms_key_arn
+  performance_insights_kms_key_arn = var.database_performance_insights_kms_key_arn
 
   database_name   = var.database_name
   master_username = var.database_master_username

diff --git a/modules/database/main.tf b/modules/database/main.tf
@@ -130,7 +130,7 @@ module "aurora" {
   // incurs a per-vcpu cost. so we can keep them for 7 days and they're free
   ////////////////////////////////////////////////////////////////////////////////////////
   performance_insights_enabled          = true
-  performance_insights_kms_key_id       = var.performance_insights_kms_key_arn == "" ? var.kms_key_arn : var.database_performance_insights_kms_key_arn
+  performance_insights_kms_key_id       = (var.performance_insights_kms_key_arn == "" || var.performance_insights_kms_key_arn == null) ? var.kms_key_arn : var.performance_insights_kms_key_arn
   performance_insights_retention_period = 7
   preferred_backup_window               = var.preferred_backup_window
   preferred_maintenance_window          = var.preferred_maintenance_window

diff --git a/modules/database/variables.tf b/modules/database/variables.tf
@@ -3,6 +3,11 @@ variable "kms_key_arn" {
   type        = string
 }
 
+variable "performance_insights_kms_key_arn" {
+  description = "Specifies an existing KMS key ARN to encrypt the performance insights data if performance_insights_enabled is was enabled out of band"
+  type        = string
+}
+
 variable "namespace" {
   type        = string
   description = "The name prefix for all resources created."