fix: Add support for out-of-band Performance Insight's being added #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
approved these changes
Jul 28, 2023
jsbroks
changed the title
zacharyblasczyk
deleted the
zacharyb/support-performance-insights-exsisting-kms-key
branch
jsbroks
pushed a commit
that referenced
this pull request
Jul 28, 2023
### [1.16.9](v1.16.8...v1.16.9) (2023-07-28) ### Bug Fixes * Add support for out-of-band Performance Insight's being added ([#114](#114)) ([210237d](210237d))
|
This PR is included in version 1.16.9 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a customer enabled Performance Insights on the DB out of band, our module won't support enabling performance insights and reconciling tf state.
AWS recommends this: https://repost.aws/knowledge-center/update-encryption-key-rds
If we just allow user's to pass this out of band KMS key, we don't need to risk DB deletion or user error and can rectify the state.