feat: Update provider deprecations #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfoucha
approved these changes
Aug 8, 2023
| condition = contains(["5.7", "8.0.mysql_aurora.3.01.0", "8.0.mysql_aurora.3.02.0"], var.database_engine_version) | ||
| error_message = "We only support MySQL: \"5.7\"; \"8.0.mysql_aurora.3.01.0\"; \"8.0.mysql_aurora.3.02.0\"." | ||
| } | ||
| default = "8.0.mysql_aurora.3.02.2" |
There was a problem hiding this comment.
I'd think we still want validation here that it's 5.7 or 8.
| @@ -27,8 +27,8 @@ variable "cluster_endpoint_public_access_cidrs" { | |||
|
|
|||
| variable "cluster_version" { | |||
| description = "Indicates AWS EKS cluster version" | |||
| nullable = false | |||
There was a problem hiding this comment.
Should we have a sane minimum here?
| resource "aws_s3_bucket" "file_storage" { | ||
| bucket = "${var.namespace}-file-storage-${random_pet.file_storage.id}" | ||
|
|
||
| force_destroy = !var.deletion_protection |
There was a problem hiding this comment.
Should this also apply to object_lock_enabled?
jsbroks
pushed a commit
that referenced
this pull request
Aug 14, 2023
## [2.1.0](v2.0.0...v2.1.0) (2023-08-14) ### Features * Update provider deprecations ([#117](#117)) ([e210dc6](e210dc6))
|
This PR is included in version 2.1.0 🎉 |
gls4
pushed a commit
that referenced
this pull request
Aug 31, 2023
* elasticache, tgt group * rm sid from iam policy docs (reduce churn) * updates + readme * fmt + default eks var * order * eks cluster version * remove "inline_policies" from iam roles * removed extren comments
gls4
pushed a commit
that referenced
this pull request
Aug 31, 2023
## [2.1.0](v2.0.0...v2.1.0) (2023-08-14) ### Features * Update provider deprecations ([#117](#117)) ([e210dc6](e210dc6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses:
aws_s3_bucket_acl,aws_s3_bucket_cors_configuration,aws_s3_bucket_ownership_controls,aws_s3_bucket_public_access_block, andaws_s3_bucket_server_side_encryption_configuration1.25in both the repository root and in theapp_eksmodule. neither sets a default or allows anullvalue, which relegates the definition of the kubernetes version used in the EKS cluster explicitly to the invocation of the module. (For example, look at the invocation of thewandb_inframodule inexamples/public-dns-external/main.tf.)inline_policiesattribute has been removed from the IAM role policies in theapp_eksmodule. the effect here is that terraform will not delete any in-line policies it finds attached to the role. this shouldn't be a problem, since we moved from inline policies to the resource-attachment style prior to the v2.0 release. Again, it's critical that upgrades to this version be executed serially to make sure that these changes are affected. if inline policies remain defined, there will be a confilct, and the result is that the policies defined in theapp_eksmodule.