feat: Added support for GCP Private Service Connect #115
Conversation
modules/private_link/main.tf
Outdated
| } | ||
|
|
||
| locals { | ||
| lb_name = data.kubernetes_ingress_v1.ingress.metadata[0].annotations != null ? data.kubernetes_ingress_v1.ingress.metadata[0].annotations["ingress.kubernetes.io/forwarding-rule"] : "" |
There was a problem hiding this comment.
lb_name but you are looking at the forward rulename?
Is this value set by the ingress controller when provisioning?
There was a problem hiding this comment.
Forwarding rule name is the actual load balancer name in gcp.
This is not being tested using the published helm version ... It will be tested after helm version upgrade to 0.13
https://github.com/wandb/helm-charts/pull/102/files
Although we have tested this locally by creating the ingress manually on the cluster .So the terraform code works
There was a problem hiding this comment.
Okay I approved the helm PR. I would perf not to use data type and pass in the name explicitly
There was a problem hiding this comment.
So lets make sure to test it with the new helm chart before we merge it
There was a problem hiding this comment.
@jsbroks ingress doesn't have any annotation that allows you specify the loadbalancer name that will be created by the gce controller .
And we need the name to link the internal load balancer to the private service .
Checked the code also there is no such supported annotation https://github.com/kubernetes/ingress-gce/blob/master/pkg/annotations/ingress.go
|
We should probably add a comment saying that this requires the min version of that helm chart in order to work. So once you merge the helm could you comment back on the chart version |
amanpruthi
force-pushed
the
aman/issue-95
branch
2 times, most recently
from
e2c3aab
to
9f8c0b0
Compare
amanpruthi
force-pushed
the
aman/issue-95
branch
from
8bb5b5c
to
d2ab582
Compare
amanpruthi
changed the title
|
it required operator wandb helm chart min version 0.13.0 |
## [3.6.0](v3.5.0...v3.6.0) (2024-07-04) ### Features * Added support for GCP Private Service Connect ([#115](#115)) ([4c47c0a](4c47c0a))
|
This PR is included in version 3.6.0 🎉 |
|
Technically this was a breaking change as you can't downgrade the version of the provider 
|
This Pr has been tested for a upgrade scenario as well as a fresh setup scenario. before this we need to publish helm chart.
PR: wandb/helm-charts#102
Required provider upgrade
terraform init -upgrade
terraform plan/apply